search

rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
684 stars 339 forks source link

Check current URI / filename are non-empty when creating body URI #1385

Closed rschlaikjer closed 1 month ago

rschlaikjer commented 1 month ago

As per the existing comment, generating URIs that are only fragments results in problems elsewhere. Log a warning but do not generate these invalid URIs.

rdiankov commented 1 month ago

Hmm.... vision relies on fragments.. see targetTemplateSceneData and detectedBodyData. You can also see behavior in order cycle orchestrator at GetTargetTemplateSceneData

Can you explain more why you need to make this change? What breaks when you don't have it? Thanks

rschlaikjer commented 1 month ago

This was a belt and suspenders check to prevent the issue addressed in controllercommon PR 849 - if these fragments are valid elsewhere in the system then perhaps this comment should just be removed?