search

rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
693 stars 343 forks source link

Fix ci.yaml's set_e #1401

Closed cielavenir closed 3 weeks ago

cielavenir commented 1 month ago

set -e does not work for things like ninja -j4 && ninja install. Need to split the command line.

https://github.com/rdiankov/openrave/actions/runs/9885745876 should fail in build stage, not test stage.

cielavenir commented 1 month ago

@felixvd @hemangandhi could you test this?

hemangandhi commented 1 month ago

@felixvd @hemangandhi could you test this?

https://github.com/rdiankov/openrave/actions/runs/9889187390 has it, https://github.com/rdiankov/openrave/actions/runs/9889146119 doesn't. Let's see what happens (I might've also fixed the build T_T)

hemangandhi commented 1 month ago

@felixvd @hemangandhi could you test this?

https://github.com/rdiankov/openrave/actions/runs/9889187390 has it, https://github.com/rdiankov/openrave/actions/runs/9889146119 doesn't. Let's see what happens (I might've also fixed the build T_T)

This worked :tada: