search

rdicosmo / parmap

Parmap is a minimalistic library allowing to exploit multicore architecture for OCaml programs with minimal modifications.
http://rdicosmo.github.io/parmap/
Other
94 stars 20 forks source link

configure needlessly checks for camlp4 #17

Closed pippijn closed 11 years ago

pippijn commented 11 years ago

I didn't find any place where the build of Parmap needs camlp4, but configure checks for it. Is there a reason for this?

UnixJunkie commented 11 years ago

If you can still build the package after this change I guess it should be OK then.

pippijn commented 11 years ago

Yes, it's not used. The configure script needs to be regenerated for this change to be effective, but I didn't do that, because I have a policy against having generated files in source code repositories.

UnixJunkie commented 11 years ago

The reason why configure is very often checked in is because it allows people who fail to generate it to still be able to compile the project.

pippijn commented 11 years ago

That makes sense, but I make tarballs for that. Anyway, this repo can do that and commit the generated configure. As long as it's not me who commits that, I'm fine with it.