search

rdicosmo / parmap

Parmap is a minimalistic library allowing to exploit multicore architecture for OCaml programs with minimal modifications.
http://rdicosmo.github.io/parmap/
Other
94 stars 20 forks source link

Init/finalize functions not called by parmapfold, parfold, and array_float_parmap. #28

Closed xclerc closed 9 years ago

xclerc commented 9 years ago

The parmapfold, parfold, and array_float_parmap functions ignore their init and finalize arguments. This implies that computations launched through these functions will not call neither init nor finalize.

rdicosmo commented 9 years ago

Many thanks Xavier for spotting this!

xclerc commented 9 years ago

You are welcome, and your library is pretty damn useful!

May I just suggest to add a line akin to <*.{ml,mli}>: warn(Ae) to the _tags file? By doing so, you will get several warnings for unused variables. Most of them seem harmless, but you should notice that finalize is ignored in setup_children_chans.

UnixJunkie commented 9 years ago

Should we do a new release because of this? Is it fixed now? I can update the opam package if needed.

rdicosmo commented 9 years ago

Thanks Francois, if you create an updated package, that will be fine; I just bumped up the version to 1.0-rc5 and pushed it to github

2014-10-20 10:28 GMT+02:00 Francois Berenger notifications@github.com:

Should we do a new release because of this? Is it fixed now? I can update the opam package if needed.

— Reply to this email directly or view it on GitHub https://github.com/rdicosmo/parmap/pull/28#issuecomment-59704718.

Roberto Di Cosmo

Professeur En delegation a l'INRIA PPS E-mail: roberto@dicosmo.org Universite Paris Diderot WWW : http://www.dicosmo.org Case 7014 Tel : ++33-(0)1-57 27 92 20 5, Rue Thomas Mann F-75205 Paris Cedex 13 Identica: http://identi.ca/rdicosmo

FRANCE. Twitter: http://twitter.com/rdicosmo

Attachments: MIME accepted, Word deprecated

http://www.gnu.org/philosophy/no-word-attachments.html

Office location:

Bureau 320 (3rd floor) Batiment Sophie Germain Avenue de France

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3

UnixJunkie commented 9 years ago

On 10/20/2014 10:54 AM, Roberto Di Cosmo wrote:

Thanks Francois, if you create an updated package, that will be fine; I just bumped up the version to 1.0-rc5 and pushed it to github

I don't see it on github.

Maybe you forgot --tags in your git command?

2014-10-20 10:28 GMT+02:00 Francois Berenger notifications@github.com:

Should we do a new release because of this? Is it fixed now? I can update the opam package if needed.

— Reply to this email directly or view it on GitHub https://github.com/rdicosmo/parmap/pull/28#issuecomment-59704718.

Roberto Di Cosmo

Professeur En delegation a l'INRIA PPS E-mail: roberto@dicosmo.org Universite Paris Diderot WWW : http://www.dicosmo.org Case 7014 Tel : ++33-(0)1-57 27 92 20 5, Rue Thomas Mann F-75205 Paris Cedex 13 Identica: http://identi.ca/rdicosmo

FRANCE. Twitter: http://twitter.com/rdicosmo

Attachments: MIME accepted, Word deprecated

http://www.gnu.org/philosophy/no-word-attachments.html

Office location:

Bureau 320 (3rd floor) Batiment Sophie Germain Avenue de France

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3

— Reply to this email directly or view it on GitHub https://github.com/rdicosmo/parmap/pull/28#issuecomment-59707428.

Regards, Francois.

rdicosmo commented 9 years ago

Thanks, re-pushed with tags

On Mon, Oct 20, 2014 at 02:07:02AM -0700, Francois Berenger wrote:

On 10/20/2014 10:54 AM, Roberto Di Cosmo wrote:

Thanks Francois, if you create an updated package, that will be fine; I just bumped up the version to 1.0-rc5 and pushed it to github

I don't see it on github.

Maybe you forgot --tags in your git command?

2014-10-20 10:28 GMT+02:00 Francois Berenger notifications@github.com:

Should we do a new release because of this? Is it fixed now? I can update the opam package if needed.

— Reply to this email directly or view it on GitHub https://github.com/rdicosmo/parmap/pull/28#issuecomment-59704718.

Roberto Di Cosmo

Professeur En delegation a l'INRIA PPS E-mail: roberto@dicosmo.org Universite Paris Diderot WWW : http://www.dicosmo.org Case 7014 Tel : ++33-(0)1-57 27 92 20 5, Rue Thomas Mann F-75205 Paris Cedex 13 Identica: http://identi.ca/rdicosmo

FRANCE. Twitter: http://twitter.com/rdicosmo

Attachments: MIME accepted, Word deprecated

http://www.gnu.org/philosophy/no-word-attachments.html

Office location:

Bureau 320 (3rd floor) Batiment Sophie Germain Avenue de France

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3

— Reply to this email directly or view it on GitHub https://github.com/rdicosmo/parmap/pull/28#issuecomment-59707428.

Regards, Francois.

— Reply to this email directly or view it on GitHub.*

Roberto Di Cosmo

Professeur En delegation a l'INRIA PPS E-mail: roberto@dicosmo.org Universite Paris Diderot WWW : http://www.dicosmo.org Case 7014 Tel : ++33-(0)1-57 27 92 20 5, Rue Thomas Mann
F-75205 Paris Cedex 13 Identica: http://identi.ca/rdicosmo

FRANCE. Twitter: http://twitter.com/rdicosmo

Attachments: MIME accepted, Word deprecated

http://www.gnu.org/philosophy/no-word-attachments.html

Office location:

Bureau 3020 (3rd floor) Batiment Sophie Germain Avenue de France

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3

UnixJunkie commented 9 years ago

It is in the pipeline:

https://github.com/ocaml/opam-repository/pull/2897

On 10/20/2014 11:29 AM, Roberto Di Cosmo wrote:

Thanks, re-pushed with tags

On Mon, Oct 20, 2014 at 02:07:02AM -0700, Francois Berenger wrote:

On 10/20/2014 10:54 AM, Roberto Di Cosmo wrote:

Thanks Francois, if you create an updated package, that will be fine; I just bumped up the version to 1.0-rc5 and pushed it to github

I don't see it on github.

Maybe you forgot --tags in your git command?

2014-10-20 10:28 GMT+02:00 Francois Berenger notifications@github.com:

Should we do a new release because of this? Is it fixed now? I can update the opam package if needed.

— Reply to this email directly or view it on GitHub https://github.com/rdicosmo/parmap/pull/28#issuecomment-59704718.

Roberto Di Cosmo

Professeur En delegation a l'INRIA PPS E-mail: roberto@dicosmo.org Universite Paris Diderot WWW : http://www.dicosmo.org Case 7014 Tel : ++33-(0)1-57 27 92 20 5, Rue Thomas Mann F-75205 Paris Cedex 13 Identica: http://identi.ca/rdicosmo

FRANCE. Twitter: http://twitter.com/rdicosmo

Attachments: MIME accepted, Word deprecated

http://www.gnu.org/philosophy/no-word-attachments.html

Office location:

Bureau 320 (3rd floor) Batiment Sophie Germain Avenue de France

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3

— Reply to this email directly or view it on GitHub https://github.com/rdicosmo/parmap/pull/28#issuecomment-59707428.

Regards, Francois.

— Reply to this email directly or view it on GitHub.*

Roberto Di Cosmo

Professeur En delegation a l'INRIA PPS E-mail: roberto@dicosmo.org Universite Paris Diderot WWW : http://www.dicosmo.org Case 7014 Tel : ++33-(0)1-57 27 92 20 5, Rue Thomas Mann F-75205 Paris Cedex 13 Identica: http://identi.ca/rdicosmo

FRANCE. Twitter: http://twitter.com/rdicosmo

Attachments: MIME accepted, Word deprecated

http://www.gnu.org/philosophy/no-word-attachments.html

Office location:

Bureau 3020 (3rd floor) Batiment Sophie Germain Avenue de France

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3

— Reply to this email directly or view it on GitHub https://github.com/rdicosmo/parmap/pull/28#issuecomment-59714605.

Regards, Francois.