search

rdicosmo / parmap

Parmap is a minimalistic library allowing to exploit multicore architecture for OCaml programs with minimal modifications.
http://rdicosmo.github.io/parmap/
Other
94 stars 20 forks source link

Support staged installation #37

Closed mansourmoufid closed 4 years ago

mansourmoufid commented 8 years ago

Hello,

In order to package parmap in pkgsrc, it needs to support "staged installation" (installing into DESTDIR). For example:

./configure --prefix=$HOME
make
mkdir .destdir
DESTDIR=$(pwd)/.destdir make install

This should install everything into the .destdir directory like so:

.destdir/home/foo/lib/ocaml/site-lib/parmap
.destdir/home/foo/share/man/man3

but at the moment it's not working.

I changed a few things in the file Makefile.in to do this properly. I removed the test for DESTDIR since it is not set during the build target but during the install target; and I changed the install target to always install to $(DESTDIR)$(PREFIX); if DESTDIR is not set this will evaluate to $(PREFIX) as usual.

UnixJunkie commented 8 years ago

So, a pull request that is not working; interesting.

UnixJunkie commented 8 years ago

Why didn't you try:

mkdir .destdir
DESTDIR=$(pwd)/.destdir
./configure --prefix=$DESTDIR
make && make install
UnixJunkie commented 8 years ago

the --prefix option of the configure script as well as the --exec-prefix options seems completely broken

rdicosmo commented 8 years ago

This part may require some love: it is the result of several successive iterations and we actually only tested the standard cases for opam install.

If you find a way to make it work properly without breaking the rest, that would be great, but all this is very fragile.

On Wed, Apr 27, 2016 at 04:54:21AM -0700, Francois Berenger wrote:

the --prefix option of the configure script as well as the --exec-prefix options seems completely broken

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub*

UnixJunkie commented 8 years ago

@eliteraspberries are you a packager for NetBSD?