search

rdicosmo / parmap

Parmap is a minimalistic library allowing to exploit multicore architecture for OCaml programs with minimal modifications.
http://rdicosmo.github.io/parmap/
Other
94 stars 20 forks source link

Fix for OCaml 4.06 #64

Closed thierry-martinez closed 6 years ago

thierry-martinez commented 6 years ago

Use bytes instead of string when mutability is required.

rdicosmo commented 6 years ago

Thanks Thierry, would you mind checking if this change breaks compilation/execution on pre 4.x OCaml compilers?

2017-11-18 1:22 GMT+01:00 thierry-martinez notifications@github.com:

Use bytes instead of string when mutability is required.

You can view, comment on, or merge this pull request online at:

https://github.com/rdicosmo/parmap/pull/64 Commit Summary

  • Fix for OCaml 4.06

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rdicosmo/parmap/pull/64, or mute the thread https://github.com/notifications/unsubscribe-auth/AAp-vxU2Gs-LoJ44Gr_TgVWdhQQdC74bks5s3iNHgaJpZM4QiyiX .

-- Roberto Di Cosmo Director Software Heritage

Professeur (on leave at/detache a INRIA) IRIF email : roberto@dicosmo.org Universite Paris Diderot web : http://www.dicosmo.org Case 7014 Twitter : http://twitter.com/rdicosmo 5, Rue Thomas Mann F-75205 Paris Cedex 13 FRANCE

Office location:

Paris Diderot INRIA

Bureau 3020 (3rd floor) Bureau C123 Batiment Sophie Germain Batiment C 8 place Aurélie Nemours 2, Rue Simone Iff Tel: +33 1 80 49 44 42

Metro Bibliotheque F. Mitterrand Ligne 6: Dugommier ligne 14/RER C Ligne 14/RER A: Gare de Lyon

GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3

thierry-martinez commented 6 years ago

The use of bytes will indeed break compilation on 4.01 and below. But I just noticed that the functions in Bytearray that requires bytes (to_string, sub, blit_to_string/bytes) are never called: I propose just to comment them.