added test for ocamlbuild

rdicosmo / parmap

Parmap is a minimalistic library allowing to exploit multicore architecture for OCaml programs with minimal modifications.

http://rdicosmo.github.io/parmap/

Other

94 stars 20 forks source link

added test for ocamlbuild #79

Closed UnixJunkie closed 4 years ago

UnixJunkie commented 5 years ago

Maybe the configure file needs to be regenerated, if my proposed change is correct

UnixJunkie commented 5 years ago

taskset commented 5 years ago

Hi @UnixJunkie , It might be simpler to modify the code here. Thanks.

diff --git a/configure.ac b/configure.ac index d0ee512..970ad3e 100644 --- a/configure.ac +++ b/configure.ac @@ -4,6 +4,9 @@ AC_PROG_OCAML if test "$OCAMLC" = "no"; then AC_MSG_ERROR([You must install the OCaml compiler]) fi +if test "$OCAMLBUILD" = "no"; then

AC_MSG_ERROR([You must install OCamlbuild (the ocamlbuild command)]) +fi

AC_PROG_FINDLIB AC_SUBST(OCAMLFIND)

UnixJunkie commented 5 years ago

If you know better, please send a proper PR. @rdicosmo can merge the best one. I am not an autoconf expert.

taskset commented 5 years ago

Hi @UnixJunkie ,Thank you. I send a another PR #80 . Code modification under your inspiration, since the AC_DEFUN ([AC_PROG_OCAML] code fragment in the m4/ocaml.m4 file has detected the existence of OCAMLBUILD, it is not necessary to define AC_PROG_OCAMLBUILD again. Thanks.