search

rdicosmo / parmap

Parmap is a minimalistic library allowing to exploit multicore architecture for OCaml programs with minimal modifications.
http://rdicosmo.github.io/parmap/
Other
94 stars 20 forks source link

4.08.0 fixes because of Bigarray.map_file moved to the Unix module #86

Closed UnixJunkie closed 5 years ago

UnixJunkie commented 5 years ago

Do not merge.

glondu commented 5 years ago

Do not merge.

Why?

UnixJunkie commented 5 years ago

Because this will not compile anymore on old ocaml versions.

glondu commented 5 years ago

Ah, right. I guess the mmap opam package was made for this kind of situation...

UnixJunkie commented 5 years ago

Nice idea, but then why this mmap package has an ocaml version constraint: "ocaml" {>= "4.02.3"}.

@rdicosmo up to how old an ocaml version do you want to support?

glondu commented 5 years ago

4.02.3 was released on 2015-07-23 and is in Debian oldstable (stretch). Do we really want to support something older?

@diml @aantron Why is the ocaml version constraint there?

aantron commented 5 years ago

I don't know why the 4.02.3 constraint is in mmap.opam at this point. It probably shouldn't be there. But 4.02 is a constraint of Dune anyway: https://github.com/ocaml/dune/blob/master/dune.opam#L30

rdicosmo commented 5 years ago

Thanks everybody for looking into all this.

Since the feature set is now fairly stable I am fine with having a newer version of Parmap that requires OCaml >= 4.0: do not hesitate in moving forward and drop pre 4.0 compatibility from now on

Roberto

Le lun. 19 août 2019 à 10:47, Francois Berenger notifications@github.com a écrit :

Nice idea, but then why this mmap package has an ocaml version constraint: "ocaml" {>= "4.02.3"}.

@rdicosmo https://github.com/rdicosmo up to how old an ocaml version do you want to support?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rdicosmo/parmap/pull/86?email_source=notifications&email_token=AAFH5PYWKJDVGGDRRWCHGK3QFJMZFA5CNFSM4IB5VEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4SFFSY#issuecomment-522474187, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFH5PZ42QQKHPUHZURZOKTQFJMZFANCNFSM4IB5VEHA .

ghost commented 5 years ago

@glondu because I only tested the build with OCaml >= 4.02.3

UnixJunkie commented 5 years ago

superseded by https://github.com/rdicosmo/parmap/pull/88