rdinnager / slimr

Run and Analyse SLiM Population Genetics Forward Simulations from R.
https://rdinnager.github.io/slimr
Other
7 stars 1 forks source link

`slim_extract_genome()` fails to extract all data #58

Closed rdinnager closed 1 year ago

rdinnager commented 2 years ago

slim_extract_genome() occasionally 'loses' some data being passed from SLiM. Usually a small amount of data but can break some examples. This is probably caused by either a change in how SLiM outputs data or possibly a change in readr. This is a high priority to fix because some manuscript examples use this.

rdinnager commented 1 year ago

A temporary solution now is to run slim_run() with progress = FALSE (which is now the default), which forces processing of output at the end of the simulation. this seems to solve the problem suggesting that the problem is with how data is processed on the fly during the simulation. It appears some part of the output slips through the cracks, which you can see by examining the slimr_result objects output slot, which contains the sections that were missed. It still only happens occasionally. I should recommend for production work, users only use progress = FALSE to make sure this does not happen. I've decided to resolve the issue with an overhaul of the output processing system which I have been planning for awhile. SHould get to that soon.

rdinnager commented 1 year ago

Workaround will do until enhancement in #66 is implemented.