Ignore `sourceType` property when comparing nodes.

rdio / jsfmt

For formatting, searching, and rewriting JavaScript.

http://rdio.github.io/jsfmt/

Other

1.69k stars 71 forks source link

Ignore `sourceType` property when comparing nodes. #162

Closed ariya closed 9 years ago

ariya commented 9 years ago

This is particularly important when you are adopting the forthcoming version of Esprima that adds sourceType to the Program node (https://github.com/jquery/esprima/issues/1159).

Without the change, the node comparison may fail and therefore some unit tests will not pass.

jimfleming commented 9 years ago

Nice, thanks for the heads up.

ariya commented 9 years ago

:+1: In addition to this, we start to include jsfmt as part of the CI process (https://github.com/jquery/esprima/pull/1288), to ensure that no future version will regress jsfmt!