search

rdio / vernacular

MIT License
170 stars 42 forks source link

Arabic (.ar) translation doesn't work #54

Open Gable82 opened 9 years ago

Gable82 commented 9 years ago

We have used vernacular for other language translations successfully, but if we try to use arabic, we just get the untranslated terms back. I've tried to use another language's strings as well for the arabic version just to test whether it is the arabic text itself that's messing with us, but even if I use any latin language for the .ar version, it still doesn't work.

EDIT: Interestingly enough, if I copied the Arabic text itself for another language (let's say Spanish resources), I will see the Arabic translation in the app. Somehow it seems like the Arabic flag is ignored in the project when it comes to recognising available languages?

Both for iOS (ar.lproj) and Android (values-ar).

stiiifff commented 8 years ago

Problem comes from the default value for pluralCount (= 1) in ResourceCatalog.GetResource. It's used to generate the resource_id which is actually using a 0 value if no plural is specified. By changing the default value of the method to 0, it works perfectly ... not sure it's the right fix though.