search

rdit-ch / itemframework

A Qt-based application framework that allows users to define units and control the flow of data between them.
https://rdit.ch
8 stars 9 forks source link

Item Bugs #20

Closed t-moe closed 7 years ago

t-moe commented 7 years ago

This MR fixes 3 bugs (#6, #7 and #17), the most critical being #6. I also fixed some Memory Leaks which I found during bugfixing.

When reviewing this, you should also review if the new cleanup strategy makes sense.

New behaviour:

  • If item's are deleted by the user (via contextmenu or pressing delete) the inputs/output connections will be removed and the corresponding signal/slots will be fired.
  • In the item's destructor (which is only invoked directly if the project get's closed or the item has no scene) the inputs/outputs will be deleted but no signals will be fired.
t-moe commented 7 years ago

Thanks for reviewing @fschlaepfer . I fixed most of your addressed concerns (we can discuss the others in the office). I've merged this now, because @Shadowigor needs this fix as well and I don't want to wait another week :grin: