Resolve TODOs or change into issues

rdk / p2rank

P2Rank: Protein-ligand binding site prediction from protein structure based on machine learning.

MIT License

251 stars 34 forks source link

Resolve TODOs or change into issues #14

Closed skodapetr closed 4 years ago

skodapetr commented 4 years ago

The p2rank code contains many TODOs, for a contributor they often do not fully explain what is needed or what is the severity of TODO.

It would be better to remove them and rather create GitHub issues with a more detailed description (what, why, how .. ).

rdk commented 4 years ago

I agree about creating GitHub issues but strongly disagree about removing TODOs. Where possible they can be linked with issues by referencing the issue id.