search

rdk / p2rank

P2Rank: Protein-ligand binding site prediction tool based on machine learning. Stand-alone command line program / Java library for predicting ligand binding pockets from protein structure.
https://rdk.github.io/p2rank/
MIT License
242 stars 34 forks source link

Commented code #16

Closed skodapetr closed 3 years ago

skodapetr commented 4 years ago

There is commented code in the source. It is not clear why and when it can be safely deleted a better practice is to not have it. A deleted code can be always recovered from GitHub.

rdk commented 3 years ago

Depends on the case, but in general I disagree. Most of is is unfinished research code and it is often useful to see what has been already tried. Having said that, some cleanup in more stable parts could be only good.