Add library dependency chain checking

sverkoye commented 3 years ago

choose lib from host (mount) or DAC rootfs depending on version tags read from "Version Definition Section", inside json file as "apiversions"
_libs.json files contain "deps" node to indicate required shared libraries. Generated by generate_libs_json.bbclass The deps are processed when deciding to mount a lib from host. All required deps should also be mounted (or taken from rootfs)
update platform files for RPI3 and 7218c reference targets

rdkcmf-jenkins commented 3 years ago

Copyright scan failure

Commit: d3ba2fdd4536d7aa9cf108c3b9ca87939fa4c388 Report detail: https://gist.github.com/7c56d3181d2a8efead8e9ee1e6c272ed

rdkcmf-jenkins commented 3 years ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/BundleGen/12/rdkcentral/BundleGen
Commit: d3ba2fdd4536d7aa9cf108c3b9ca87939fa4c388

Report detail: gist

mhughesacn commented 3 years ago

Hi Stefan, As this is a Consult Red repo, please will you add an entry to NOTICE with the LGI copyright:

Thanks, Martin

sverkoye commented 3 years ago

Hi Stefan, As this is a Consult Red repo, please will you add an entry to NOTICE with the LGI copyright:

Copyright 2020 Liberty Global Licensed under the Apache License, version 2.0

Thanks, Martin

Done

rdkcmf-jenkins commented 3 years ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/BundleGen/12/rdkcentral/BundleGen
Commit: 518b5974f65b44089bac448426f71a3969285863

Report detail: gist

rdkcmf-jenkins commented 3 years ago

Copyright scan failure

Commit: 518b5974f65b44089bac448426f71a3969285863 Report detail: https://gist.github.com/f047456347a3ee7fa26be38de2413563

rdkcmf-jenkins commented 3 years ago

Copyright scan failure

Commit: 518b5974f65b44089bac448426f71a3969285863 Report detail: https://gist.github.com/3933513ffd3f9bcd7efe9ee93df36f4c

rdkcmf-jenkins commented 3 years ago

WARNING: A Copyright scan failure has been waived

A prior failure has been upvoted

Upvote reason: Thanks Stefan
Commit: 518b5974f65b44089bac448426f71a3969285863

rdkcmf-jenkins commented 3 years ago

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: Thanks Stefan
Commit: 518b5974f65b44089bac448426f71a3969285863

rdkcmf-jenkins commented 3 years ago

Copyright scan failure

Commit: c5542661f901f2fbe0c5cac3df0bfdabeeaa10fe Report detail: https://gist.github.com/3c5bad07d4f8a191b8ba7de8ba83fdb4

rdkcmf-jenkins commented 3 years ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/BundleGen/12/rdkcentral/BundleGen
Commit: c5542661f901f2fbe0c5cac3df0bfdabeeaa10fe

Report detail: gist

rdkcmf-jenkins commented 3 years ago

Copyright scan failure

Commit: c78d8a3eb915f2ace08acd8cdcf25923aae2df59 Report detail: https://gist.github.com/df7fc0b742a564c84575d47c1c53c59e

rdkcmf-jenkins commented 3 years ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/BundleGen/12/rdkcentral/BundleGen
Commit: c78d8a3eb915f2ace08acd8cdcf25923aae2df59

Report detail: gist

sverkoye commented 3 years ago

Hi Stefan. Generally looks good to me! Need to do a bit more testing to make sure the generated bundles work as expected, but code-wise I'm happy.

A few minor general comments:

Some of the log messages would make more sense to be trace level (logger.trace()) to avoid quite such a huge output. Trace level logs can still be viewed with -vvv

bundle_processor.py is getting pretty large and unwieldy now. I think it would be a good idea to split out the _mount_or_use_rootfs method (and dependent methods like _take_host_lib()) into a new class.

Updated most logging to trace level and moved libmatching code to separate file (library_matching.py)

rdkcmf-jenkins commented 3 years ago

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: Fixed in the tool
Commit: c78d8a3eb915f2ace08acd8cdcf25923aae2df59

rdkcmf-jenkins commented 3 years ago

WARNING: A Copyright scan failure has been waived

A prior failure has been upvoted

Upvote reason: Fixed in the tool
Commit: c78d8a3eb915f2ace08acd8cdcf25923aae2df59

rdkcentral / BundleGen