search

rdkcentral / BundleGen

A command-line tool to convert OCI Images into extended OCI Bundles for use with the Dobby container manager.
Apache License 2.0
5 stars 32 forks source link

Modified code to support  user provided appmetadata without confirmat… #86

Closed PriyaPesala closed 1 year ago

PriyaPesala commented 1 year ago

…ion when user provided the path in arguments.

To support appmetadata when user has given appmetadata as input and oci image is also having appmetadata, In that case it is choosing appmetadata from user over oci image.

PriyaPesala commented 1 year ago

As the User is providing the app meta data path purposely in the argument, we have decided to remove the confirmation prompt which is replica. In case if we handle the confirmation with the yes argument, as there is one more confirmation prompt (for deleting the existing bundle) we cannot use the same yes for both, in case if we want to pass different options, we need to add one more optional parameter for the app meta data confirmation. Please suggest how to proceed further. 

PriyaPesala commented 1 year ago

@TeknoVenus can you suggest, if any modifications are required.

TeknoVenus commented 1 year ago

Apologies for the late reply...

Understand. So to confirm, if there's app metadata in the image & app-metadata provides as an argument, the argument always takes priority. That sounds reasonable.

Can you please add an info log message when this occurs just to make it obvious, but other than that it looks good to me