search

rdkcentral / Lightning-SDK

SDK for Lightning framework
Apache License 2.0
130 stars 69 forks source link

Change pages using by using numeric keyboard on routes #115

Closed jhderojasUVa closed 4 years ago

jhderojasUVa commented 4 years ago

I guess is a feature but I don't see it on the documentation or it's a bug.

After creating a new application by lng create or (on the old one) removing the node_modules/wpe-lightning*, package-lock.json and doing a npm i (so the versions and modules are the latest), if you do an application with routes (and on the routes file you create put them in some order) when you do the lng dev and the application shows on the browser, you can move show a page by pressing 1, 2, 3, 4... etc (depending of the number of pages you have an the order they are on the routes file).

Is there any way to disabling this on dev? (something to put on the settings.json file).

I have take a look in the SDK at the src/Router/utils.js to see the properties that are used on the routes but I don't see anything related.

erikhaandrikman commented 4 years ago

Hi, this is indeed a feature to quickly test the first defined routes. Since the new release yesterday you now need to configure it: https://github.com/rdkcentral/Lightning-SDK/blob/6ce64fd58ce36d96c6ac4309e00626bb3459dcce/src/Router/index.js#L1068

So by default it's disabled and you can enable it by adding numberNavigation: true to the platform router settings

erikhaandrikman commented 4 years ago

Can we close this issue?

jhderojasUVa commented 4 years ago

Jajaja, yes, of course... xDDD