Closed michielvandergeest closed 3 years ago
See some code comments inline.
In general, I'm not sure about the separate namespacing of
Advertising
andPersonalization
.Managing entitlements and watch history might deserve its own separate Plugin?
And things like
adSkipTier
seems like some kind of a user / devicePreference
? Maybe from a developer perspective it might make sense to introduce something likePlatform.Preferences.adSkipTier
along side other preference settings.
Hmmm. There's currently two separate features in the Advertising
namespace:
I don't think they belong in Preferences, but i could be convinced we need a new place...
Closing this PR since we've switched to separate smaller PRs for specific plugins (ie. Discovery, Authentication, Metrics).
@jlacivita creating a PR to make it easier to comment on the changes