rdkcentral / Lightning-SDK

SDK for Lightning framework
Apache License 2.0
130 stars 69 forks source link

Patch 1 #161

Closed michielvandergeest closed 3 years ago

michielvandergeest commented 3 years ago

@jlacivita creating a PR to make it easier to comment on the changes

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

jlacivita commented 3 years ago

See some code comments inline.

In general, I'm not sure about the separate namespacing of Advertising and Personalization.

Managing entitlements and watch history might deserve its own separate Plugin?

And things like adSkipTier seems like some kind of a user / device Preference? Maybe from a developer perspective it might make sense to introduce something like Platform.Preferences.adSkipTier along side other preference settings.

Hmmm. There's currently two separate features in the Advertising namespace:

I don't think they belong in Preferences, but i could be convinced we need a new place...

michielvandergeest commented 3 years ago

Closing this PR since we've switched to separate smaller PRs for specific plugins (ie. Discovery, Authentication, Metrics).