search

rdkcentral / Lightning-SDK

SDK for Lightning framework
Apache License 2.0
130 stars 69 forks source link

Lightning Router Docs incorrect #237

Closed chiefcll closed 3 years ago

chiefcll commented 3 years ago

http://www.lightningjs.io/docs/#/lightning-sdk-reference/plugins/router/configuration?id=accessing-data-from-route-components

As far as I can tell - the params are not added to the page instance... they are added as page.params.

https://github.com/rdkcentral/Lightning-SDK/blob/779e85aff338f812b411ab4cbcd7fe2fd7a1b9bd/src/Router/utils/provider.js#L90

erikhaandrikman commented 3 years ago

Thanks for pointing this out, we will update the documentation

erikhaandrikman commented 3 years ago

Thanks for pointing this out. This was deprecated behaviour and was already updated in the docs: https://github.com/rdkcentral/Lightning-SDK/blob/master/docs/plugins/router/configuration.md#accessing-data-from-route-components but somehow the change didn't found it's way to the docs on lightningjs.io

This will be updated in the next docs release