search

rdkcentral / Lightning-SDK

SDK for Lightning framework
Apache License 2.0
130 stars 69 forks source link

Deeplinks break in 4.8.0 #321

Closed yvbeek closed 2 years ago

yvbeek commented 2 years ago

In our app we use deep-links so that we can send the user to a specific show or episode. This was working well, but it is no longer working after we've upgraded to 4.8.0.

I noticed that deep-links are still working for known routes (those that have been passed to Router.startRouter), but we are using a fallback mechanism that if the deep-link is not a known route, that we grab that page from our CMS and display the content in our app. This no longer works in 4.8.0.

Edit: the commit that seems to break our functionality is: https://github.com/rdkcentral/Lightning-SDK/commit/2957ad1c6a087ad64a0bd6266e05799c22a9d4b3 Edit 2: after more testing it seems that version 4.4.0 also broke part of this functionality: https://github.com/rdkcentral/Lightning-SDK/blob/master/CHANGELOG.md#v440

michielvandergeest commented 2 years ago

Hi @yvbeek, thank you for your report.

Would it be possible to share a sample application displaying the issue, so we can reproduce that and look at a fix?

michielvandergeest commented 2 years ago

Hi @yvbeek, is this still an issue? Or can we close this?