search

rdkcentral / Lightning-SDK

SDK for Lightning framework
Apache License 2.0
130 stars 69 forks source link

Remove opinionated smooth behavior from VideoTexture #327

Closed mauro1855 closed 2 years ago

mauro1855 commented 2 years ago

Hi team,

As mentioned in #326, the VideoPlayer plugin behaviour is currently inconsistent when running in textureMode vs. non-textureMode. Particularly, the inconsistency lies in the immediate effect of CSS styling vs the delayed and animated effect of the smoothed property updates in textureMode. Additionally, a developer using the SDK has no control over the animation parameters, which makes the current implementation very opinionated.

I hope you don't find this change too radical, since the objective is to make the behaviour of the VideoPlayer consistent in both textureMode and non-textureMode and provide a more predictable developer experience.

Best regards, Mauro

michielvandergeest commented 2 years ago

Thanks for your PR @mauro1855.

Starting v5.0.0 the VideoPlayer plugin is no longer part of the Lightning-SDK. It’s been moved to the Metrological-SDK.

The PR itself looks good to me though! So I would suggest to recreate this PR at the metrological-sdk to get it merged in there.