search

rdkcentral / Lightning-SDK

SDK for Lightning framework
Apache License 2.0
130 stars 69 forks source link

playAfterSeek in VideoPlayer not working #328

Closed mauro1855 closed 2 years ago

mauro1855 commented 2 years ago

Hi SDK team,

The VideoPlayer plugin currently has some logic on seek() to resume video playback if it was already playing when seek() was called. You can find the logic here and then here.

Unfortunately this is currently not working - the playback doesn't resume. I checked with @bjornvanspengen and @tomvdbroek and we believe the issue lies in the fact that the play() is called before the video player is ready to play after the seek.

I think the player needs to wait for the canplay player event before it can play. I will be submitting a PR with this solution soon.

michielvandergeest commented 2 years ago

Hi @mauro1855, thanks for your report.

Starting v5.0.0 the VideoPlayer plugin is no longer part of the Lightning-SDK. It’s been moved to the Metrological-SDK.

I’m not able to move issues between organizations, so I would suggest to open this issue as a new ticket over here.