Wait for canplay event before playing after seek

rdkcentral / Lightning-SDK

SDK for Lightning framework

Apache License 2.0

130 stars 69 forks source link

Wait for canplay event before playing after seek #329

Closed mauro1855 closed 2 years ago

mauro1855 commented 2 years ago

PR to address #328

This solution doesn't work in Safari, but the previous code also didn't work there, so nothing lost. I checked a couple of STBs and confirmed this addresses the issue of not resuming playback after seek.

michielvandergeest commented 2 years ago

Thanks for your PR @mauro1855.

Starting v5.0.0 the VideoPlayer plugin is no longer part of the Lightning-SDK. It’s been moved to the Metrological-SDK.

The PR itself looks good to me, only point of attention is to make sure the event listener gets properly removed from the video element upon app close.

I would suggest to recreate this PR at the metrological-sdk to get it merged in there.