search

rdkcentral / Lightning-SDK

SDK for Lightning framework
Apache License 2.0
130 stars 69 forks source link

VideoPlayer gets width and height from platformSettings #331

Closed ricardo-a-alves-alb closed 2 years ago

ricardo-a-alves-alb commented 2 years ago

According to RuntimeConfiguration, the width and height of the viewport is defined on the Stage Configuration using the w and h parameters.

However, in the VideoPlayer plugin, it is trying to read width and height from the platformSettings. I believe this is not intended. I will provide a PR fixing this.

https://github.com/rdkcentral/Lightning-SDK/blob/82b8948ca0e7efe7afe5a94ba5700d21a9cc880c/src/VideoPlayer/index.js#L127-L132

michielvandergeest commented 2 years ago

Hi @ricardo-a-alves-alb, thanks for your report.

Starting v5.0.0 the VideoPlayer plugin is no longer part of the Lightning-SDK. It’s been moved to the Metrological-SDK.

I’m not able to move issues between organizations, so I would suggest to open this issue as a new ticket over here.