Use ipaddress as userId if userId is missing

rdkcentral / mock-firebolt

An advanced, controllable mock Firebolt OS implementation, which can also act as a reverse proxy to a real Firebolt OS running on a real device

Apache License 2.0

4 stars 21 forks source link

Use ipaddress as userId if userId is missing #39

Closed naimish15 closed 2 years ago

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Naimish Patel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

michaelcfine commented 2 years ago

I don't think the logic added is quite right, but even if it is, it isn't sufficient... user ids have to 'formally' exist before they can be used (see isKnownUser), so at the very least, you'll need to also add the user with the given userId (IP#). See https://github.com/rdkcentral/mock-firebolt/blob/main/server/src/index.mjs#L63. Note that you have to add the user and then also set up default state for that user (hence the two separate calls).

naimish15 commented 2 years ago

I was facing some issues in this PR so I will create new PR