search

rdkcentral / rdk-halif-libdrm

LibDRM manages the graphics and display hardware, providing a direct interface between the graphics hardware and the Westeros Renderer. This repo includes the documentation for libdrm
Apache License 2.0
0 stars 0 forks source link

Rdk dev #1

Closed aleeta-thomson closed 11 months ago

rdkcmf-jenkins commented 1 year ago

Copyright scan failure

Commit: accd26c093ab6792603bbd575a3755d89900de50 Report detail: https://gist.github.com/rdkcmf-jenkins/3116d80dcda8e1638dac339fdfb7f9da

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 5 files pending identification.

rdkcmf-jenkins commented 1 year ago

Copyright scan failure

Commit: d35526383547f77dc974d271bc8d0761d1a10ee4 Report detail: https://gist.github.com/rdkcmf-jenkins/f574a915f64aabf5a5af0c7f6d9e8d4c

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 5 files pending identification.

rdkcmf-jenkins commented 1 year ago

Copyright scan failure

Commit: d35526383547f77dc974d271bc8d0761d1a10ee4 Report detail: https://gist.github.com/rdkcmf-jenkins/b57a74f742febc6210865ad4020308cd

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 5 files pending identification.

rdkcmf-jenkins commented 1 year ago

Copyright scan failure

Commit: 985d8b1f97d73d0182c974b092898c97c4667ff0 Report detail: https://gist.github.com/rdkcmf-jenkins/069151d7ec0140e38ab1b4d696ea1100

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 5 files pending identification.

rdkcmf-jenkins commented 1 year ago

Copyright scan failure

Commit: 3e2f12d28a92a1b03e0a92d914e53baa23a10d4e Report detail: https://gist.github.com/rdkcmf-jenkins/22159883f8d98d9339d06c1aaaf554dd

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 5 files pending identification.

mhughesacn commented 1 year ago

Hi Aleeta: I finally scanned this for compliance and request the following:

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

mhughesacn commented 1 year ago

Hi Aleeta: Please check NOTICE - I wanted to keep the last line because it still applies (about the include directory) - please check back on the version of NOTICE on which I commented, lines 8 and 24.

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

kupr-24814 commented 1 year ago

Hi Martin, as per the discussion we had with review team, they have suggested us to remove the header files. For any other updation, it needs to be approved by the review team.

rdkcmf-jenkins commented 11 months ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

rdkcmf-jenkins commented 11 months ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

rdkcmf-jenkins commented 11 months ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

kupr-24814 commented 11 months ago

For the recent comments, I have unresolved the conversations so that you can confirm from your end too. I have marked by commenting done or okay or thumbs up. For Licensing, I'll get back after having a discussion with Martin.

[EDIT: have updated the 3 files (https://github.com/rdkcentral/rdk-halif-libdrm/pull/1/commits/5c6e1d355ccb60e21ddee91796af03fab52e6a46) ]

rdkcmf-jenkins commented 11 months ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

rdkcmf-jenkins commented 11 months ago

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

kupr-24814 commented 11 months ago

Hi @hari22yuva

for 1st one:

replace with
drmHandleEvent() is used to handle events that are received by the caller from the DRM module.
Supported events are hotplug, mode change, page flip, and VBlank events

is hotplug, mode change events required for our platforms ?

i checked in the code and we are using drmHandleEvent only for pageFlip event so the necessary event currently that is required to be supported for drmHandleEvent is page flip. i have reframed the statement as this:

`drmHandleEvent()` is used to handle events that are received by the `caller` from the `DRM` module.
Required supported events is page flip event.

for 2nd one:

usually drmModeSetPlane() is called before rendering the frame please drmModeSetPlane() above drmModePageFlip() in the sequence diagram

drmModeSetPlane is called in a few if conditions. one of them is after drmModePageFlip; so since it was requested to add drmModePageFlip, i had to add drmModeSetPlane also as per my understanding i am adding drmModeSetPlane for 1 more condition (i.e, when video plane's Last Frame flag is not set) in the sequence diagram as per your suggestion. you can also refer here: https://code.rdkcentral.com/r/plugins/gitiles/components/opensource/westeros/+/refs/heads/master/drm/westeros-gl/westeros-gl.c

rdkcmf-jenkins commented 11 months ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 3 files pending identification.

mhughesacn commented 11 months ago

Hi Priyanka: Fixed the blackduck problem. The changes look OK to me.

rdkcmf-jenkins commented 11 months ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

rdkcmf-jenkins commented 11 months ago

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

srinivasgtl commented 11 months ago

ship it.