Fix segmentation fault on invalid SMARTS

rdkit-rs / rdkit

RDKit Made Idiomatic for Rust

16 stars 11 forks source link

Fix segmentation fault on invalid SMARTS #19

Open aleebberg opened 10 months ago

aleebberg commented 10 months ago

Fixes #18

JJ-Pineda commented 10 months ago

Thank you @aleebberg for finding this! We have been fixing pointer issues lately and looks like we missed this one. @xrl I'm going to merge this as it seems to be a good stop-gap measure, but we probably want to look into what's happening to the pointer in rdkit.

JJ-Pineda commented 10 months ago

@aleebberg Clippy is mainly complaining about a space before an "=" sign. Would you mind adding that?

Also, the failed test looks to be related to an issue we introduced on our side (i.e. making a mutable romol). Feel free to add that "mut" if you like.

xrl commented 10 months ago

I enabled github actions for this PR, now you can see the formatting errors here: https://github.com/rdkit-rs/rdkit/actions/runs/7128018658/job/19420335878?pr=19#step:7:1211 .

aleebberg commented 8 months ago

Hi, @xrl I was just wondering if you already had a second look at my PR. I think I might need your permission for github actions as well. It would be great to merge it since I need the PR for benchmarking the code I implemented for my master thesis. :)