search

rdkit / conda-rdkit

Conda build recipe for the rdkit
51 stars 30 forks source link

implemented alternative versioning mechanism to __conda_version__ (issue #53) #58

Closed ptosco closed 5 years ago

ptosco commented 6 years ago

This change, coupled with the changes in the rdkit master branch, allows building the rdkit and rdkit-postgresql on newer conda version where __conda_version__ has been obsoleted, and fixes issue #53.

greglandrum commented 6 years ago

The other PR is now merged.

ptosco commented 6 years ago

OK, I have changed ptosco into rdkit. However I left in master instead of Release_2017_09 or the build will fail due to missing pkg_version.py. This is why git is whinging about a conflict.

greglandrum commented 6 years ago

I can fix the conflicts pre-merge. no problem there.

bp-kelley commented 6 years ago

@ptosco , could you see if #53 helps on windows with conda 3 versioning? I'm unclear if this is related to what you are trying to do with windows

ptosco commented 6 years ago

@bp-kelley the check_VS2017.bat thing is a separate, Windows-only issue, to fix the fact that conda does not play well with the mess that Microsoft did with the new VS2017 directory tree. Instead, #53 is the issue that pkg_version.py is addressed to. Instead of using the obsolete __conda_version__, it uses load_setup_py_data() to extract the version info from CMakeLists.txt and RDKitUtils.cmake. I hope this makes things a bit clearer.

greglandrum commented 6 years ago

is it ok if I let you guys figure this out and just wait for you to tell me what the answer is? I wouldn't be sad to focus on some other stuff. :-)