search

rdkit / conda-rdkit

Conda build recipe for the rdkit
50 stars 30 forks source link

Updates conda version to conda 3.0 compatible version #59

Closed bp-kelley closed 6 years ago

bp-kelley commented 6 years ago

This commit uses Nico Pulver's idea to change the version to be the last tag from the revision plus the number of commits sense.

I.e. in the master branch, this would be the last release like 2017.09.1.100 where the release is 2017.09.1 and has 100 commits since that tag.

For a particular revision, it will be that revisions tag modified by some python magic, i.e. 

tag.replace("Release_","")

and so on.

bp-kelley commented 6 years ago

@greglandrum @rvianello I think this works under conda 3 and earlier.

greglandrum commented 6 years ago

FWIW: if I start with a clean miniconda3 install (conda 4.3.30) and try to conda build the rdkit using this version the python tests all seg fault.

The build works fine on my ubuntu machine.

This all reminds me that we should really do travis integration for this repo. But that's another PR.