search

rdkit / homebrew-rdkit

Homebrew formula for rdkit
44 stars 19 forks source link

it takes ages to compile this formula #49

Closed UnixJunkie closed 6 years ago

UnixJunkie commented 6 years ago

use make -j nprocs instead of make

UnixJunkie commented 6 years ago

@hsiaoyi0504 any idea why the CI tests are failing on this?

hsiaoyi0504 commented 6 years ago

@UnixJunkie sorry, I don't have any idea. It looks that just make -j 2 not work. Can you point me where you see this option for rdkit ?

UnixJunkie commented 6 years ago

I saw that rdkit compiles using a single core on my Mac. Instead, I would like it to use all available cores instead (because it takes ages to compile the whole rdkit).

mcs07 commented 6 years ago

Weird, I would expect this to work fine.

Looking at other formulas, there are a variety of ways it is specified: https://github.com/Homebrew/homebrew-core/search?utf8=%E2%9C%93&q=system+make+ENV.make_jobs&type=

Maybe try without the space:

system "make", "-j#{ENV.make_jobs}"

or

system "make", "--jobs=#{ENV.make_jobs}"
hsiaoyi0504 commented 6 years ago

Another weird thing, I test this using @mcs07 suggestion, but it looks like the make become even slower and can't pass the test https://travis-ci.org/hsiaoyi0504/homebrew-rdkit/jobs/327720427.

UnixJunkie commented 6 years ago

thanks for the proposals. I am trying without the space.

hsiaoyi0504 commented 6 years ago

@UnixJunkie it looks like the update method working now. Can you squash the commits together? I think the few trying stuffs are not so important to be included into the git history.

UnixJunkie commented 6 years ago

please merge this PR, thanks.

hsiaoyi0504 commented 6 years ago

I think this can be closed now. @UnixJunkie I just open a new pull request #51 where I squash the commits together as single commit and you are still the original commiting author to the changes. :)

UnixJunkie commented 6 years ago

Ok, sorry for the squash thing. Github allows to merge by squashing commits at the same time I think.