rdkit / homebrew-rdkit

Homebrew formula for rdkit
44 stars 19 forks source link

Dependency collector parsing deprecation #53

Closed theavey closed 6 years ago

theavey commented 6 years ago

Updating homebrew today with brew update gives me a few warnings about deprecated dependency parsing:


Warning: Calling 'depends_on :python3' is deprecated!
Use 'depends_on "python3"' instead.
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:88:in `parse_spec'

Warning: Calling 'depends_on :postgresql' is deprecated!
Use 'depends_on "postgresql"' instead.
/usr/local/Homebrew/Library/Taps/rdkit/homebrew-rdkit/Formula/rdkit.rb:24:in `<class:Rdkit>'
Please report this to the rdkit/rdkit tap!

Warning: Calling 'depends_on :python' is deprecated!
Use 'depends_on "python"' instead.
/usr/local/Homebrew/Library/Taps/rdkit/homebrew-rdkit/Formula/rdkit.rb:32:in `<class:Rdkit>'
Please report this to the rdkit/rdkit tap!```
mcs07 commented 6 years ago

Should be fixed by #52

zmactep commented 6 years ago

Yes, #52 fixes this. Please merge the PR.