search

rdkit / homebrew-rdkit

Homebrew formula for rdkit
44 stars 19 forks source link

Migrate to pip method of Python package install #76

Closed maksbotan closed 4 years ago

maksbotan commented 4 years ago

This is a follow-up to https://github.com/rdkit/rdkit/pull/2690

For demonstration, HEAD URL was changed to my branch. It must be changed back once RDKit PR is merged, along with URL to the new release.

UnixJunkie commented 4 years ago

Why do you use pip instead of pip3? Python2 is no more supported by rdkit and pip is the installer for python2 packages.

maksbotan commented 4 years ago

First of all, take a look at the rdkit pr I linked. Then, notice that I do not call pip directly, but rather with #{python_executable} -m pip, which selects just right pip (that's how the module is called in python 3 as well) for brew's python.

UnixJunkie commented 4 years ago

Ok. You should try updating the .travis.yml file in your PR.

maksbotan commented 4 years ago

No problem, will do today.

UnixJunkie commented 4 years ago

In another issue, the submitter said that this PR is no more necessary.