KNIME-1695: Onboarding for KNIME 5.1

manuelschwarze commented 1 year ago

Updated Copyright to 2023
Updated Jenkinsfile (for NIBR only)
Updated MANIFEST.MF files to accept KNIME <6.0.0
Created target platform files for 5.1 and nightly
Updated launch files
Adapted RDKit Fingerprint Reader and Writer test (removed for now failing deprecated File Reader node as we refactor the nodes anyway soon) - original zip files is kept under manual-zips
Bugfix in FunctionalGroupFilterNodeDialog due to init changes of KNIME

For the moment it seems the changes are backward-compatible also with KNIME 4.7, therefore we will keep the version number

Open issue: RDKitInteractiveView, which is used in the RDKit Interactive Table Node, the RDKit SMILES Headers Node, and the RDKit Substructure Counter Node is not working anymore, but fails to be found by KNIME (seems to be a KNIME bug or "feature").

greglandrum commented 1 year ago

@manuelschwarze do you want to merge this even though the RDKitInteractiveView piece isn't working?

manuelschwarze commented 1 year ago

Even if the RDKit Interactive View is currently not working in KNIME 5.1, I would still merge it to master (and even the release) for three reasons:

I think, this is a bug in KNIME and will be fixed on their side (if not they will need to communicate what we need to change)
It is working fine in KNIME 4.x, so it will affect only KNIME 5.x
It is better for a user to have 98% of RDKit functionality than 0%

greglandrum commented 1 year ago

@manuelschwarze : I think this is fine to merge whenever you're happy with it.

rdkit / knime-rdkit

KNIME-1695: Onboarding for KNIME 5.1 #132