search

rdlester / hermes

A game engine for rapid world prototyping in Processing/Java:
https://rdlester.github.io/hermes/
MIT License
48 stars 4 forks source link

Rectangle scale method #3

Closed blasmena closed 10 years ago

blasmena commented 10 years ago

public void scale(float xScale, float yScale) { assert xScale > 0 : "scale: xScale must be greater than zero"; assert yScale > 0 : "scale: yScale must be greater than zero";

    _min.x *= xScale;
    _max.x *= xScale;
    _min.y *= yScale;
    _min.y *= yScale;
}

It should be _max.y *= yScale at the last line in scale. I'm not sure, but it would explain why it isn't working for me. I've recently found this library and I'm really enjoying it. Sorry if I have bad english, I'm from Chile.

rdlester commented 10 years ago

Good catch. I'll try to get a fix up ASAP.

blasmena commented 10 years ago

Thanks! I'm loving the interaction subscribing system, keeps my code quite clean and decoupled.

2014-04-21 20:02 GMT-03:00 Ryan Lester notifications@github.com:

Good catch. I'll try to get a fix up ASAP.

Reply to this email directly or view it on GitHubhttps://github.com/rdlester/hermes/issues/3#issuecomment-40986904 .

rdlester commented 10 years ago

Fixed and pushed. Thanks for the report! Glad to hear you like the library.

blasmena commented 10 years ago

The bug fix allowed me to finish my little experiment, thanks again. You can check the game in http://gamejolt.com/games/arcade/monos/25536/

Thanks a lot again.