rdmenezes / cefpython

Automatically exported from code.google.com/p/cefpython
1 stars 0 forks source link

Client handler not set for popup windows #123

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
No callbacks from client handler are called for popup windows. In cefpython 
29.2 the LifespanHandler.`OnBeforePopup` was implemented, but the client 
handler for the popup is not being set.

Parameter:

  CefRefPtr[CefClient]& client,

It should be fine to set the main client handler, I don't think that it is 
required to create a separate handler for popups. The CreateBrowserSync() 
function is already creating multiple ClientHandler objects in subsequent calls.

  client = <CefRefPtr[ClientHandler]?>new ClientHandler()

Original issue reported on code.google.com by czarek.t...@gmail.com on 25 May 2014 at 6:12

GoogleCodeExporter commented 9 years ago

Original comment by czarek.t...@gmail.com on 25 May 2014 at 6:14

GoogleCodeExporter commented 9 years ago
The client handler callbacks are executed fine for popups. In OnBeforePopup the 
docs state:

  The |client| and |settings| values will default to the source browser's values. 

Original comment by czarek.t...@gmail.com on 29 Jul 2014 at 9:09