search

rdmenezes / crashrpt

Automatically exported from code.google.com/p/crashrpt
0 stars 0 forks source link

CRASHRPT_VER can differ in sources and project files when generating solutions with CMake #149

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When the CRASHRPT_VER CMake variable and the define in CrashRpt.h differ, the 
correct CrashSender application is not found.
This could be fixed by using

# CrashRpt version number
set (CRASHRPT_VER 1301)
add_definitions( -DCRASHRPT_VER=${CRASHRPT_VER} )

in CMakeLists.txt in the main directory and removing the define from CrashRpt.h

Original issue reported on code.google.com by Schoenle...@googlemail.com on 6 May 2012 at 1:41

GoogleCodeExporter commented 9 years ago 
CRASHRPT_VER definition in CrashRpt.h is required for compatibility.  Some 
client applications may use the definition for checking current CrashRpt 
version. I suppose I can't remove it.

Original comment by zexspect...@gmail.com on 10 May 2012 at 6:36

GoogleCodeExporter commented 9 years ago 
I can not imagine the situation when these variable and define are different 
(except when someone wants to upgrade CrashRpt version manually). IMHO this is 
not a problem for 99,9% of users.

Original comment by zexspect...@gmail.com on 25 Aug 2012 at 2:30