Closed GoogleCodeExporter closed 9 years ago
Original comment by zexspect...@gmail.com
on 22 Oct 2010 at 2:51
Please provide more information:
1. What version of CrashRpt did you use?
2. I do not see a mistake in the XmlEncodeStr code.
std::string CCrashHandler::XmlEncodeStr(CString sText)
encoding the text ascii use "return std::string(strconv.t2a(sResult));"
Since the sResult string was already UTF-8-encoded and stored as ASCII, there
is nothing bad in expanding it to wide char, then replacing the restricted
characters and converting to ASCII. Am I wrong?
3. Are you sure your replaceInPlace function really "replaces in place"? I see
that it creates another string named "result" and copies the source string to
it, then swaps result and source. Is this called "in-place"?
4. Why do you return std::string(pszEncodedStr)?
isn't it correct to return std::string(str);
Original comment by zexspect...@gmail.com
on 30 Oct 2010 at 7:03
1.when I used Ver.1.2.3 , it'ok, updated to ver.1.2.7 , i got the error!
2."the sResult string was already UTF-8-encoded" but "expanding it to wide
char" is error, CString is wrong.
3.i just get "replaceInPlace" from "Poco"( refrence http://pocoproject.org/)
for replace CString
4.oh , i was wrong, your are wright
Original comment by liling...@gmail.com
on 1 Nov 2010 at 1:38
Fixed in v.1.2.8
Original comment by zexspect...@gmail.com
on 15 Feb 2011 at 3:43
Original issue reported on code.google.com by
liling...@gmail.com
on 22 Oct 2010 at 6:44