Closed GoogleCodeExporter closed 9 years ago
In: int CMiniDumpReader::StackWalk(DWORD dwThreadId)
I see this line:
dwMachineType==IMAGE_FILE_MACHINE_I386?NULL:(&Context), // used for non-I386
machines
should there be support for other machine types like so:
#ifdef _X86_
dwMachineType==IMAGE_FILE_MACHINE_I386?NULL:&Context, // used for non-I386 machines
#elif defined _AMD64_
dwMachineType==IMAGE_FILE_MACHINE_AMD64?NULL:&Context, // used for non-I386 machines
#else
dwMachineType==IMAGE_FILE_MACHINE_I386?NULL:&Context, // used for non-I386 machines
#endif
Original comment by crcod...@gmail.com
on 21 Nov 2009 at 5:09
Related to
dwMachineType==IMAGE_FILE_MACHINE_I386?NULL:(&Context), // used for non-I386
machines
I think the current code is correct, but I'll review this.
Original comment by zexspect...@gmail.com
on 22 Nov 2009 at 11:44
Original comment by zexspect...@gmail.com
on 23 Dec 2009 at 7:09
Original issue reported on code.google.com by
crcod...@gmail.com
on 21 Nov 2009 at 5:09