rdmenezes / crashrpt

Automatically exported from code.google.com/p/crashrpt
0 stars 0 forks source link

Clarification for CR_INST_DONT_SEND_REPORT & CR_AF_TAKE_ORIGINAL_FILE #75

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Reference Closed Issue#69

CrashRpt 1.2.7 & 1.2.8

The closure of Issue#69 was a documentation change, but it failed to address 
the specific flags used with the original issue.

My original issue does *not* use the CR_INST_SEND_QUEUED_REPORTS flag, but in 
this instance I am using the CR_INST_DONT_SEND_REPORT flag. This was not 
mentioned in my bug report since the documentation of the 
CR_INST_SEND_QUEUED_REPORTS flag affecting the behaviour of 
CR_AF_TAKE_ORIGINAL_FILE in crAddFile2() was of course not present.

For the record, this is my CR_INSTALL_INFO::dwFlags setting:

CR_INST_ALL_EXCEPTION_HANDLERS | CR_INST_DONT_SEND_REPORT | 
CR_INST_STORE_ZIP_ARCHIVES

I understand the queued reports could lead to the file not being in the crash 
folder.  However, it is not clear to me why this should be the case when the 
report is not sent at all.

As I see it, this is resolved two ways:

a) The crAddFile2() is updated again to reflect that CR_AF_TAKE_ORIGINAL_FILE 
cannot be used when the CR_INST_DONT_SEND_REPORT is set. I must admit I am not 
sure why that would be the case - no delay is incurred in this situation 
leading to inconsistent results; or

b) A code change takes place such that CR_AF_TAKE_ORIGINAL_FILE works correctly 
when the CR_INST_DONT_SEND_REPORT flag is set.

Original issue reported on code.google.com by gmacaus...@gmail.com on 16 Feb 2011 at 6:44

GoogleCodeExporter commented 9 years ago

Original comment by zexspect...@gmail.com on 17 Feb 2011 at 3:22

GoogleCodeExporter commented 9 years ago
Updated documentation for crAddFile2() function. Fixed in v.1.2.9.

Original comment by zexspect...@gmail.com on 2 Apr 2011 at 6:59