search

rdmenezes / crashrpt

Automatically exported from code.google.com/p/crashrpt
0 stars 0 forks source link

Crash report is not discarded when 'Close the program' is selected. #94

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
CErrorReportSender::Finalize() only deletes the current error report when 
g_CrashInfo.m_bQueueEnabled is FALSE.
However, when CErrorReportDlg::OnPopupCloseTheProgram() is called the user 
expect the error report to not be sent and not be queued. A quick fix is to add:

  Utility::RecycleFile(g_CrashInfo.GetReport(0).m_sErrorReportDirName, true);

back to CErrorReportDlg::OnPopupCloseTheProgram(). Maybe changing Finalize() is 
the cleaner option. On the other hand, when sending is successful the error 
report is also deleted outside of Finalize().

Original issue reported on code.google.com by asch...@gwdg.de on 30 Jun 2011 at 9:40

GoogleCodeExporter commented 9 years ago

Original comment by zexspect...@gmail.com on 31 Jul 2011 at 3:38

GoogleCodeExporter commented 9 years ago 
I'm trying to understand what the problem is. But... 

"On the other hand, when sending is successful the error report is also deleted 
outside of Finalize()." 

I can't find the place outside the Finalize() where the error report is 
deleted. Can you tell me what file/line do you mean? What CrashRpt version do 
you use? Do you expirience this problem in CrashRpt v.1.2.10?

Original comment by zexspect...@gmail.com on 6 Oct 2011 at 3:46

GoogleCodeExporter commented 9 years ago 
Couldn't reproduce the issue with v.1.2.10. No responce from issue reporter. 
Closing.

Original comment by zexspect...@gmail.com on 22 Oct 2011 at 11:03

GoogleCodeExporter commented 9 years ago 
Sorry for not answering to this earlier.

With the quoted sentence I meant that when successfully sending the report 
directly, the RecycleFile call is made in CErrorReportSender::SendReport(). If 
sending is not successful, the report is queued (which is reasonable).

I have tested with the current trunk and I can reproduce the error:
Start CrashReportTest and crash it. The crash report is generated in the 
UnsentErrorReports folder. 
Now select 'Close the program' - the error reports remains there and will be 
listed later just as if 'Close the program and send report later' had been 
chosen.

Original comment by Schoenle...@googlemail.com on 6 May 2012 at 2:23

GoogleCodeExporter commented 9 years ago

Original comment by zexspect...@gmail.com on 10 May 2012 at 6:40

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r1336.

Original comment by zexspect...@gmail.com on 25 Aug 2012 at 5:42

GoogleCodeExporter commented 9 years ago 
Fixed in rev. 1336 of trunk.

Original comment by zexspect...@gmail.com on 25 Aug 2012 at 5:42