rdmenezes / synecdoche

Automatically exported from code.google.com/p/synecdoche
GNU Lesser General Public License v3.0
0 stars 0 forks source link

Don't shuffle project list in attach project wizard #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The Attach project wizard currently shows the project list in random 
order, intentionally. The list is shuffled each time you open the wizard.

Apparently, this is so people don't always click on the first ones; so 
they see all the projects. This seems... pretty daft to me.

I, and at least three other users in #boinc, request that this list is 
sorted alphabetically.

Original issue reported on code.google.com by nicolas....@gmail.com on 16 Sep 2008 at 9:21

GoogleCodeExporter commented 9 years ago
By the way, the shuffling code currently adds a field with a random number to 
each 
project, and sorts the list using that field as key. It would be more efficient 
(O(n), vs O(n*log n) or O(n²) for the sort algorithm), and also be clearer, if 
it 
used std::random_shuffle.

Original comment by nicolas....@gmail.com on 16 Sep 2008 at 9:27

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
I removed the list-shuffling code from the manager, and noticed the list is 
also 
shuffled on the *server* when it's downloaded! (so the client-side shuffle was 
useless).

Original comment by nicolas....@gmail.com on 17 Sep 2008 at 2:21

GoogleCodeExporter commented 9 years ago
Fixed in r327 and r328.

Original comment by nicolas....@gmail.com on 17 Sep 2008 at 3:29

GoogleCodeExporter commented 9 years ago

Original comment by nicolas....@gmail.com on 17 Sep 2008 at 3:29

GoogleCodeExporter commented 9 years ago
Works fine. Code looks good. I like fixes that involve removing convoluted and 
pointless code....

Original comment by didacty...@gmail.com on 22 Sep 2008 at 3:16

GoogleCodeExporter commented 9 years ago

Original comment by didacty...@gmail.com on 27 Jun 2009 at 1:32