rdmorganiser / .github

Community health files for the @rdmorganiser organization
Apache License 2.0
0 stars 1 forks source link

Set up reusable workflows for GHA #15

Open afuetterer opened 1 month ago

afuetterer commented 1 month ago

I would like to have a few reusable workflows for common CI tasks (e.g. the lint job with pre-commit) in a central location.

They could be used in rdmo and plugins repos like this:

"uses: rdmorganiser/.github/.github/workflows/_lint.yml@main"

Maybe they should live in a "dedicated" top.level workflows or reusable-workflows directory. They could even have their own repo like https://github.com/rdmorganiser/workflows.

This would reduce duplication and have one central place to maintain.

What do you think?

Refs:

MyPyDavid commented 1 month ago

thanks @afuetterer, this is a really great idea!

For the plugins, for example, this PR https://github.com/rdmorganiser/rdmo-plugins-radar/pull/1 needs to be adapted and included in here so that each plugin can run a sort of 'sanity check' via this common workflow. I'm going to look into it after the current release.

afuetterer commented 1 month ago

Excellent. I remembered vaguely, that there was a discussion on how to test the plugin installation with rdmo and testing config in CI. I see, it was the radar plugin.

I think the "common" CI jobs, like lint, dev-setup etc. can move here.

Testing rdmo is very different from testing a plugin, I guess.