search

rdmorganiser / rdmo-docker-compose

RDMO running in different docker images held together by docker compose
Apache License 2.0
3 stars 12 forks source link

chore: install rdmo[postgres] optional dependency #26

Closed afuetterer closed 9 months ago

afuetterer commented 9 months ago

Hi @triole,

rdmo 2.0.0 can be installed with optional dependencies like pip install rdmo[postgres]. No need for pip installing psycopg2 separately.

Sometimes you used pip3 and pip in the dockerfile, I switched them all to python -m pip.

I was unsure about the rdmo url yet:

Will this syntax work? python -m pip install "${RDMO_INSTALL_URL}"[postgres]

triole commented 9 months ago

Hi @afuetterer, thanks for your suggestions. The python -m pip is unproblematic but unfortunately the psycopg2 part breaks the whole docker setup. In addition it is a little early to make these changes because rdmo2 is not even released yet. But when the release is out I plan to do a little maintenance work for this repo. I know that the setup is old and needs a effort because there there are several things that can be improved or simplified.

afuetterer commented 9 months ago

I see, of course, please wait for rdmo v2. This PR is in draft mode. I just wanted to make this suggestion for once v2 is released.

afuetterer commented 9 months ago

v2 is now releases, python -m pip rdmo[postgres] works now.

Will this work as well? python -m pip install "${RDMO_INSTALL_URL}"[postgres]

afuetterer commented 9 months ago

Maybe you can also use a python base image? But I am no Docker expert, I am sure you have valid reasons for using Debian as the base.