search

rdmorganiser / rdmo

A tool to support the planning, implementation, and organization of research data management.
https://rdmorganiser.github.io
Apache License 2.0
105 stars 49 forks source link

Short title for Section and Page #1017

Closed jochenklar closed 5 months ago

jochenklar commented 5 months ago

This PR adds a new field short_title to Section and Page. If set, this field populates the navigation instead of the title which might be to long. See also https://github.com/rdmorganiser/rdmo/issues/363 and https://github.com/rdmorganiser/rdmo/issues/346.

MyPyDavid commented 5 months ago

I think I would need to add this to the import (https://github.com/rdmorganiser/rdmo/pull/810) afterwards as well

jochenklar commented 5 months ago

No sorry I don't think we need tests here. The only thing which could be tested is that short_title is used and not title if it is set. I don't want to mess with the fixtures just for that. :confused:

jochenklar commented 5 months ago

Ah crap and to the export!

MyPyDavid commented 5 months ago

yes, I think to have a model field represented in a test fixture should be a minimum or not??

jochenklar commented 5 months ago

I don't think we need that every time. We need to update the fixtures and the xml files at one point in the future, but not now.

jochenklar commented 5 months ago

Force push after interactive rebase.