Fix import element sorting when saving (for related items)

MyPyDavid commented 4 months ago

Description

Fixes for the Import Feature

revert order function back to original (pre dev-2.2.0) append_element
- that fixes the order of m2m parts in uploaded elements
- needed to cast the order through field items to int
removes keys from the uploaded element that are not relevant for the import (like legacy keys)
type casting of certain fields (extra_fields) is done by the instance.full_clean() and these instance values are written back into the element[field]
- for example, to properly see the differences, the uploaded value needs to be case to float for FloatField otherwise a str will be compare to float

Motivation and Context

Made an overview of the models and the relations with the CLI tool graph_models

/manage.py graph_models conditions options domain questions tasks views -g --relation-fields-only=True --no-inheritance -x=created,updated,editors,sites,groups -l=dot -o rdmo_content_relations.svg

rdmo_content_relations

How has this been tested?

Screenshots (if appropriate)

Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] Refactoring (no functional changes, no api changes)

Checklist

[x] I have read the contributor guide.
[x] My code follows the code style of this project.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.

MyPyDavid commented 3 months ago

I broke the sorting with append_element with a typo before in the import feature branch. Am now reverting it back to original sorting, but get a RecursionError for the legacy tests..

typo, it should be value instead of element_value in: https://github.com/rdmorganiser/rdmo/blob/ea118edba99fc8ac45934883794b8a4515309d6e/rdmo/core/xml.py#L451