Fix addValueSet in project_questions - Githubissues

rdmorganiser / rdmo

A tool to support the planning, implementation, and organization of research data management.

https://rdmorganiser.github.io

Apache License 2.0

105 stars 49 forks source link

Fix addValueSet in project_questions #1108

Closed jochenklar closed 3 months ago

jochenklar commented 3 months ago

~~Run refresh check, progress and navigation update, and conditions check when a new value set is added.~~

This PR adds updateProgress and updateView to service.js. The idea is, that:

updateProgress is called on each service.save and service.addValueSet and service.removeValueSet, and
updateView on service.save, but only when service.initView is not called. It contains the check if an optionset needs a refresh, the update of the navigation, and the re-evaluation of the conditions (and was named postSave for a few days).

jochenklar commented 3 months ago

Bonus track: the last commit allow to use the navigation when a validation error ist triggered.