Use EXPORT_CONTENT_DISPOSITION for project xml export

rdmorganiser / rdmo

A tool to support the planning, implementation, and organization of research data management.

https://rdmorganiser.github.io

Apache License 2.0

105 stars 49 forks source link

Use EXPORT_CONTENT_DISPOSITION for project xml export #1149

Closed jochenklar closed 1 week ago

jochenklar commented 2 months ago

Right now, an XML project export is always shown in the browser. Changed management XML exports to be always downloaded (controlled by settings.EXPORT_CONTENT_DISPOSITION). This PR adds the same behavior for XML project exports.

jochenklar commented 2 months ago

An additional Problem with not downloading the file right away, is that users might copy-paste the content displayed in the browser, which is not the complete XML (e.g. namespaces are missing).

MyPyDavid commented 1 month ago

this one is for 2.3.0 right? (was not for 2.2.2 or?)

jochenklar commented 1 month ago

Mhm, we could have added that to 2.2.2, but its fine I guess.

jochenklar commented 1 month ago

Or for 2.2.3 :stuck_out_tongue:

MyPyDavid commented 2 weeks ago

Could you maybe rebase this on a proper release branch? Are the changes just a single commit?

jochenklar commented 1 week ago

Rebased and ready (after tests are ok).