rdmorganiser / rdmo

A tool to support the planning, implementation, and organization of research data management.
https://rdmorganiser.github.io
Apache License 2.0
103 stars 49 forks source link

incorrect export of options #206

Closed xokoxk closed 4 years ago

xokoxk commented 4 years ago

an exported set of options includes the tag \<text>, which should be . The import expects the <title> tag. Presumably an issue in <a rel="noreferrer nofollow" target="_blank" href="https://github.com/rdmorganiser/rdmo/blob/master/rdmo/options/serializers/export.py">https://github.com/rdmorganiser/rdmo/blob/master/rdmo/options/serializers/export.py</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/triole"><img src="https://avatars.githubusercontent.com/u/11279151?v=4" />triole</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>I have difficulties to understand what kind problem you have observed because <code><text></code> tags in exported xml files seem to be correct. My test imports of these files went well. What do you mean by "the import expects the <title> tag"?</p> <p>Please could you explain a little more? What did you do? Which kind of error did occur?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/xokoxk"><img src="https://avatars.githubusercontent.com/u/65657734?v=4" />xokoxk</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>ooops, sorry - i got the description of the issue all mixed up. The tag-problem is actually the other way round: An exported set of options includes the tag <title>, but it actually should be <text> (see e.g. <a href="https://github.com/rdmorganiser/rdmo-catalog/blob/master/rdmorganiser/options/rdmo.xml">https://github.com/rdmorganiser/rdmo-catalog/blob/master/rdmorganiser/options/rdmo.xml</a>). </p> <p>if an imported option does not include the <text> tag, the option has no "name" - for the user, the option will be available, but there is no text to it. Since the import is still successful, there is no error message. So, when you reproduced the options import, you did create new options, but they (presumably) don't have any text. </p> <p>I hope I could clear this one up - sorry for the confusion.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/triole"><img src="https://avatars.githubusercontent.com/u/11279151?v=4" />triole</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Thank you, your explanation helped a little. I understood that you get options xml files that do have <code><title></code> instead of <code><text></code>. Obviously this doesn't work because the import wouldn't find any text belonging to these "broken" options. So far so good. </p> <p>My only problem is that my export does not behave like this. When I export from my local RDMO there is not a single <code><title></code> inside my xml file. So I am really interested in how you achieved that? Unfortunately I lack an illuminating idea. Which RDMO version are you running? Do you have any kind of modifications? Did you run the migrations? How does your <code>local.py</code> look like? Sorry for asking, all these questions but I try to get an impression what could have gone wrong.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>