search

rdmorganiser / rdmo

A tool to support the planning, implementation, and organization of research data management.
https://rdmorganiser.github.io
Apache License 2.0
100 stars 47 forks source link

Switch to redux toolkit from legacy redux #876

Open afuetterer opened 9 months ago

afuetterer commented 9 months ago

Refs:

jochenklar commented 9 months ago

I looked at redux toolkit when I started working on the new management. I thought it was to complicated for what I wanted to archive. Back then, I was not used to use hooks though. I like how the redux store is set up now, and I would rather not change it ...

Same for React Router btw. (Although am an not sure anymore if it was so clever to implement routing myself.

Another tool I was considering was redux-persist, but again, it seemed to much overhead and to complicated compared to the solution we now have.

Maybe we should reconsider this. I can have a look when I am working on the new interview next year.

afuetterer commented 9 months ago

I just opened this issue here, because the dependabot wanted to update react and redux and everything started failing.

Which is of course a good thing, the basic frontend tests are working.

The referenced release notes in #869 state, that the redux authors intend users to switch to redux-toolkit.

I have no strong opinion about this at all.

jochenklar commented 9 months ago

Alright, then future-Jochen needs to solve this! :cry:

MyPyDavid commented 6 months ago

bump future-Jochen, maybe want to look into this again before more React parts are added to the code-base?

jochenklar commented 3 months ago

I did look into it and I don't get the new way for our rather complex ajax calls. I will stick for the pattern in management for now. In the end this can be refactored later.