search

rdmtc / node-red-contrib-sun-position

This is a ultimate Node-Red Timer, Sun, Moon and Blind flow control.
Apache License 2.0
110 stars 25 forks source link

Migration to ver 2.x from 1.x #375

Open GasTurbineMan opened 2 years ago

GasTurbineMan commented 2 years ago

Using 2 nodes "Inject Enhanced" and "Moon Position" from version 1.x and just updated Sun-Position to 2.0.6. From JSON output of version 1.x Moon Position, I was using: lastUpdateStr.illumination.phase.pos replaced by lastUpdateStr.illumination.phase.weight ?? (not sure this is correct) lastUpdateStr.illumination.phase.value replaced by lastUpdateStr.illumination.phaseValue lastUpdateStr.illumination.fraction still lastUpdateStr.illumination.fraction

Can you confirm the correct data objects (listed on the right above) that replaced the old version data objects? Likewise, can you explain any data range differences if any between the old object format and the new object.

GasTurbineMan commented 2 years ago

My issue appears mainly with how I was using .illumination.phase.pos in the prior version which always returned an integer between 0 and 7 which does not appear to be included in the output of the new version. At first, I thought it to be .illumination.phase.weight as the data at the time was a "1" but then the next day, I was seeing a non-integer output of "6.3825". Ironically today, it is back to "1" so I would assume .illumination.phase.weight is not what I need to be using.

GasTurbineMan commented 2 years ago

To add to my observations after the v2.x upgrade, it is now December 11th here in USA and MoonPosition is still showing to be in "First Quarter" position; however, the First Quarter was yesterday. I am also seeing where Illumination Fraction only changes about every 8 hours even though I repeat timestamp injection every hour.

Thanks for looking into this.

GasTurbineMan commented 2 years ago

While I was using the integer value of the earlier version's "phase.position" data, I am able to work around not having that data by simply using the "phase.name" string data that is provided.

I restate my issue as follows: 1> Comment on any data range changes for "illumination.fraction" and "illumination.phaseValue" for new version in comparison to similar data from earlier version. 2> Comment on why I am not seeing any change in values on the 2 data points above for several hours even though I am injecting a new timestamp every hour.

Thanks